Skip to content

protocols/kad: Support multiple protocol names#2846

Merged
mxinden merged 6 commits intolibp2p:masterfrom
dmitry-markin:multiple-kademlia-protocol-names
Sep 3, 2022
Merged

protocols/kad: Support multiple protocol names#2846
mxinden merged 6 commits intolibp2p:masterfrom
dmitry-markin:multiple-kademlia-protocol-names

Conversation

@dmitry-markin
Copy link
Contributor

@dmitry-markin dmitry-markin commented Aug 25, 2022

Description

Add support for multiple Kademlia protocol names to allow protocol name upgrades.

Links to any relevant issues

Resolves #2837.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmitry-markin for the patch!

mxinden
mxinden approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @dmitry-markin for the follow-ups.

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

@mxinden mxinden changed the title Support multiple Kademlia protocol names protocols/kad: Support multiple protocol names Sep 2, 2022
@dmitry-markin
Copy link
Contributor Author

dmitry-markin commented Sep 2, 2022

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

Sure, can do this. @mxinden, meanwhile, could you merge this PR — GitHub says "Only those with write access to this repository can merge pull requests."

@mxinden mxinden merged commit cee199a into libp2p:master Sep 3, 2022
@mxinden
Copy link
Member

mxinden commented Sep 3, 2022

@dmitry-markin do you need a new release soonish, or is depending on master unblocking you for now?

@dmitry-markin
Copy link
Contributor Author

dmitry-markin commented Sep 3, 2022

@mxinden substrate consumes libp2p from crates.io, so having the changes released would be great. Nevertheless, it's not something super urgent.

@dmitry-markin dmitry-markin mentioned this pull request Sep 3, 2022
Merged
4 tasks
@dmitry-markin
Copy link
Contributor Author

dmitry-markin commented Sep 3, 2022

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

A follow-up PR that removes the deprecated methods: #2866.

@dmitry-markin dmitry-markin mentioned this pull request Sep 3, 2022
Closed
@mxinden mxinden mentioned this pull request Sep 5, 2022
Merged
5 tasks
This was referenced Sep 15, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxinden mxinden mxinden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the possibility to negotiate fallback Kademlia protocol names

2 participants

@dmitry-markin @mxinden